Skip to content

Say when the release actually stops for approval - #40

Merged
Veneury merged 1 commit into
mainfrom
docs/release-approval-gate
Sep 28, 2026
Merged

Veneury merged 1 commit into
mainfrom
docs/release-approval-gate

Conversation

@Veneury

@Veneury Veneury commented Sep 28, 2026

Copy link
Copy Markdown
Owner

RELEASING.md said the workflow waits for approval before pushing. It waits before starting: the job runs inside the nuget environment, so GitHub holds it at step zero. Approving means "start this release", not "these packages look right" — nothing is built, tested or packed until it happens, and once it does the job runs to the end without stopping again.

That is still worth having, because a tag pushed by accident publishes nothing on its own. But it is not the review the document described, and the difference decides whether the gate is any use: seeing the packages before deciding needs the job split in two, with only the pushing half in the environment. That is written down now rather than left to be discovered.

NUGET_USER is named rather than described, because describing it was not enough. It is the nuget.org account that created the policy, which is not always the one that owns the packages, and nuget.org says exactly that in the error when it is wrong. The 401 it fails with is now in the recovery list, along with the part that matters: the tag does not need to move, re-running the failed job is enough.

RELEASING.md said the workflow waits for approval before pushing. It waits before starting: the
job runs inside the nuget environment, so GitHub holds it at step zero. Approving means "start
this release", not "these packages look right" — nothing is built, tested or packed until it
happens, and once it does the job runs to the end without stopping again.

That is still worth having, because a tag pushed by accident publishes nothing on its own. But
it is not the review the document described, and the difference decides whether the gate is any
use: seeing the packages before deciding needs the job split in two, with only the pushing half
in the environment. That is written down now rather than left to be discovered.

NUGET_USER is named rather than described, because describing it was not enough. It is the
nuget.org account that created the policy, which is not always the one that owns the packages,
and nuget.org says exactly that in the error when it is wrong. The 401 it fails with is now in
the recovery list, along with the part that matters: the tag does not need to move, re-running
the failed job is enough.
@Veneury
Veneury merged commit 5db71ce into main Sep 28, 2026
7 checks passed
@Veneury
Veneury deleted the docs/release-approval-gate branch September 28, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant